Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if mbsync -v is less than 1.4.0 use old format, else use new format #956

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

if mbsync -v is less than 1.4.0 use old format, else use new format #956

wants to merge 1 commit into from

Conversation

arosl
Copy link

@arosl arosl commented Jul 31, 2023

Replace the check of apt-get with a check that looks at the version number of mbsync and use the old format if the version number is less than 1.4.0

@arosl
Copy link
Author

arosl commented Jul 31, 2023

fixes #936

@LukeSmithxyz
Copy link
Owner

You checked for it being not equal to 1.4.0.

Also, sort -V is not posix compliant.

@medicalwei
Copy link

medicalwei commented Sep 4, 2023 •
edited
Loading

According to their releases:
https://sourceforge.net/projects/isync/files/isync/

I think a simple string compare should work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arosl @LukeSmithxyz @medicalwei